Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jsdom/jsdom
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v29.0.0
Choose a base ref
...
head repository: jsdom/jsdom
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v29.0.1
Choose a head ref
  • 7 commits
  • 14 files changed
  • 3 contributors

Commits on Mar 15, 2026

  1. Modernize release infrastructure

    - Add tag-triggered publish workflow (npm publish via GitHub Actions OIDC)
    - Remove Changelog.md in favor of GitHub Releases
    - Remove AUTHORS.txt, .mailmap, and the update-authors script
    - Add MAINTAINERS.md with releasing instructions and release notes style guide
    
    Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
    domenic and claude committed Mar 15, 2026
    Configuration menu
    Copy the full SHA
    e528859 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2026

  1. Fix border shorthand parsing

    Closes #4112.
    asamuzaK authored Mar 19, 2026
    Configuration menu
    Copy the full SHA
    d589a8e View commit details
    Browse the repository at this point in the history
  2. Wrap getComputedStyle return value for proper indexed access

    getComputedStyle() was returning the webidl2js impl directly instead of the wrapper since f29722d. The wrapper's Proxy is needed for indexed property access (e.g. cs[0]) and the supportedPropertyIndices/supportsPropertyIndex protocol.
    
    Fixes 18 previously-failing WPT tests: the 16 all-prop-revert-*-noop tests, serialize-all-longhands, and cssstyledeclaration-custom-properties (partially — one sub-test still fails due to custom property ordering).
    
    Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
    domenic and claude committed Mar 19, 2026
    Configuration menu
    Copy the full SHA
    0b79509 View commit details
    Browse the repository at this point in the history
  3. Handle global keywords in CSS shorthand property handlers

    Several shorthand property handlers (border, background, and their sub-shorthands) crashed or produced incorrect results when encountering CSS-wide keywords like "inherit" or "initial". The root cause is that `parse()` functions return strings for global keywords, but many callers assumed object/array returns.
    
    - In `processBorderProperties`, handle global keywords uniformly at the top of the loop before any property-specific branching, fixing `cssText = "border-top: inherit"` (and all border side/line shorthands) which previously threw a TypeError swallowed by the cssText setter's catch block.
    - In `matchesBorderShorthandValue`, return false for non-object parse results, fixing `border: inherit` followed by setting a longhand like `borderTopWidth`.
    - In `prepareBorderStringValue` and `prepareBorderObjectValue`, guard `replacePositionValue` calls against global keyword inputs, fixing `border: inherit` followed by setting a sub-shorthand like `borderTop`.
    - In `background.parse()`, return global keywords as strings (matching `border.parse()` behavior). Update the descriptor setter to propagate them to all longhands and the getter to verify longhand consistency before returning.
    - In `prepareProperties`, skip `replaceBackgroundShorthand` for global keyword shorthands, and fix a pre-existing Map mutation-during-iteration bug by updating `parsedProperties` instead of `properties`.
    - Mark `cssom-setProperty-shorthand.html` as passing.
    
    Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
    domenic and claude committed Mar 19, 2026
    Configuration menu
    Copy the full SHA
    1e8a7ff View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2026

  1. Configuration menu
    Copy the full SHA
    5f2434c View commit details
    Browse the repository at this point in the history
  2. Add benchmark for computed style property access

    Measures lazy resolution: accessing individual computed style properties via getPropertyValue after getComputedStyle, for both few (4) and many (30) properties.
    
    Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
    domenic and claude committed Mar 20, 2026
    Configuration menu
    Copy the full SHA
    8ffc811 View commit details
    Browse the repository at this point in the history
  3. 29.0.1

    domenic committed Mar 20, 2026
    Configuration menu
    Copy the full SHA
    34c7d6e View commit details
    Browse the repository at this point in the history
Loading