Fix the valueMissing check for <input type=radio>

zjffun · web-flow · commit c2fb8ff94917 · 2020-08-08T12:49:16.000-04:00
diff --git a/lib/jsdom/living/nodes/HTMLInputElement-impl.js b/lib/jsdom/living/nodes/HTMLInputElement-impl.js
@@ -332,11 +332,11 @@ class HTMLInputElementImpl extends HTMLElementImpl {
     return null;
   }
 
-  _isRadioGroupChecked() {
-    if (this.checked) {
+  _someInRadioGroup(name) {
+    if (this[name]) {
       return true;
     }
-    return this._otherRadioGroupElements.some(radioGroupElement => radioGroupElement.checked);
+    return this._otherRadioGroupElements.some(radioGroupElement => radioGroupElement[name]);
   }
 
   get _mutable() {
@@ -976,7 +976,7 @@ class HTMLInputElementImpl extends HTMLElementImpl {
             // and all of the input elements in the radio button group have a checkedness
             // that is false, then the element is suffering from being missing.
             case "radio":
-              if (this._required && !this._isRadioGroupChecked()) {
+              if (this._someInRadioGroup("_required") && !this._someInRadioGroup("checked")) {
                 return true;
               }
               break;
diff --git a/test/web-platform-tests/to-run.yaml b/test/web-platform-tests/to-run.yaml
@@ -656,7 +656,6 @@ DIR: html/semantics/forms/constraints
 
 form-validation-validity-valueMissing.html: [fail, 'Spec unclear (see https://github.com/whatwg/html/issues/5202)']
 infinite_backtracking.html: [timeout, We cannot restrict duration of regex matching from JavaScript]
-radio-valueMissing.html: [fail, fix https://github.com/zjffun/jsdom/commits/fix/radio-value-missing]
 
 ---
 

Original file line number	Diff line number	Diff line change
`@@ -332,11 +332,11 @@ class HTMLInputElementImpl extends HTMLElementImpl {`
`332`	`332`	`return null;`
`333`	`333`	`}`
`334`	`334`
`335`		`- _isRadioGroupChecked() {`
`336`		`- if (this.checked) {`
	`335`	`+ _someInRadioGroup(name) {`
	`336`	`+ if (this[name]) {`
`337`	`337`	`return true;`
`338`	`338`	`}`
`339`		`- return this._otherRadioGroupElements.some(radioGroupElement => radioGroupElement.checked);`
	`339`	`+ return this._otherRadioGroupElements.some(radioGroupElement => radioGroupElement[name]);`
`340`	`340`	`}`
`341`	`341`
`342`	`342`	`get _mutable() {`
`@@ -976,7 +976,7 @@ class HTMLInputElementImpl extends HTMLElementImpl {`
`976`	`976`	`// and all of the input elements in the radio button group have a checkedness`
`977`	`977`	`// that is false, then the element is suffering from being missing.`
`978`	`978`	`case "radio":`
`979`		`- if (this._required && !this._isRadioGroupChecked()) {`
	`979`	`+ if (this._someInRadioGroup("_required") && !this._someInRadioGroup("checked")) {`
`980`	`980`	`return true;`
`981`	`981`	`}`
`982`	`982`	`break;`