Use --fgrep for npm run test:tuwpt:browser

domenic · domenic · commit 54f9995300ee · 2026-03-12T16:45:59.000+09:00
This makes it uniform with other npm run test:* commands.
diff --git a/scripts/verify-tuwpts-in-browser.js b/scripts/verify-tuwpts-in-browser.js
@@ -9,10 +9,11 @@
 // https://web-platform-tests.org/running-tests/from-local-system.html#system-setup
 //
 // Usage:
-//   node scripts/verify-tuwpts-in-browser.js [--browser=chrome] [filter ...]
+//   node scripts/verify-tuwpts-in-browser.js [--browser=chrome] [--fgrep domparsing]
 //
-// Filters are substring matches against test paths. Without filters, all to-upstream tests are
-// included. Use --browser (-b) to specify a browser command; otherwise opens the default browser.
+// `--fgrep` values are substring matches against test paths. Without them, all to-upstream tests
+// are included. Use --browser (-b) to specify a browser command; otherwise opens the default
+// browser.
 
 /* eslint-disable no-console */
 
@@ -210,12 +211,13 @@ async function main() {
   const manifest = regenerateManifest(toUpstreamDir, resolve(wptDir, "tuwpt-manifest.json"));
   const testPaths = getPossibleTestFilePaths(manifest).map(p => "/" + p);
 
-  const { values: { browser }, positionals: filters } = parseArgs({
-    allowPositionals: true,
+  const { values: { browser, fgrep } } = parseArgs({
     options: {
-      browser: { type: "string", short: "b" }
+      browser: { type: "string", short: "b" },
+      fgrep: { type: "string", multiple: true }
     }
   });
+  const filters = fgrep ?? [];
   const filtered = filters.length > 0 ?
     testPaths.filter(p => filters.some(f => p.includes(f))) :
     testPaths;
diff --git a/test/to-port-to-wpts/PORTING.md b/test/to-port-to-wpts/PORTING.md
@@ -13,8 +13,8 @@ After creating or modifying to-upstream tests, verify they pass in a real
 browser:
 
 ```sh
-npm run test:tuwpt:browser                   # all to-upstream tests
-npm run test:tuwpt:browser -- domparsing     # substring filter
+npm run test:tuwpt:browser                        # all to-upstream tests
+npm run test:tuwpt:browser -- --fgrep domparsing  # substring filter
 ```
 
 This starts the WPT Python server, opens your default browser, runs the tests,
