Resolve case-sensitivity at prepare time#305
Conversation
344b177 to
62b41a2
Compare
c4d1b16 to
2fb76b0
Compare
domenic
left a comment
There was a problem hiding this comment.
This doesn't quite do what I suggested. It looks up the case-sensitivity of the property every time the setter is called, which is not necessary. Instead the case-sensitivity should be looked up at prepare-time, so that when we generate lib/generated/propertyDescriptors.js, the calls look like createGenericPropertyDescriptor("animation-name", { caseSensitive: true }).
|
Looking back at the PR, I wondered if it would be better to combine generatePropertyDefinitions.mjs and generatePropertyDescriptors.mjs into a single file. |
domenic
left a comment
There was a problem hiding this comment.
Looking back at the PR, I wondered if it would be better to combine generatePropertyDefinitions.mjs and generatePropertyDescriptors.mjs into a single file.
WDYT?
I think this is a good idea. It is very related to the discussion at #304 (comment).
But, let me merge this first as it is a good improvement by itself.
Another approach to fix #303
Closes #304