This repository was archived by the owner on Mar 23, 2024. It is now read-only.
disallowTrailingWhitespace: use CST for fix method#2180
Closed
Conversation
Member
|
It seems there is a jshint error? |
Member
|
Friendly ping |
Member
|
It seems we still have couple failures? |
26d2034 to
265a7b2
Compare
Member
Author
test/lib/assertHelpers.js
Outdated
| var result = checker.fixString(options.input); | ||
| expect(result.errors).to.have.no.errors(); | ||
| expect(result.output).to.equal(options.output); | ||
| if (result.output !== options.output) { |
Member
Author
There was a problem hiding this comment.
Dono why I've added it. Need to drop
3e28111 to
8f63819
Compare
8f63819 to
3a16cf0
Compare
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @markelog @hzoo