Compiler macro and FULL (!!!) format implementation from CMUCL #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Amazing stuff. Do we need to keep some license notice or something below the GPL to keep credit to CMUCL? |
davazp
approved these changes
Dec 8, 2025
Member
Author
I credited CMUCL in my top level comment. I don't think we need to reproduce any notice because CMUCL is public domain. SBCL also just has a single sentence crediting CMUCL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ports the full FORMAT implementation from CMUCL to JSCL!!!
Also implemented proper compiler macro. Using the compiler macro, the full FORMAT implementation (essentially compiler-only) is even faster than the previous incomplete FORMAT implementation (interpreter-only) at run time.
tests.jsruns about 20% faster on node.Some of this might be attributed to
codegen.lispnow usesimple-formatinstead offormat. This is necessary for bootstrapping (the compiler-only FORMAT implementation has to call the compiler). But IMO this is also cleaner becausecodegen.lispabsolutely don't need the full functionality of FORMAT, and this makes bootstrapping dependency simpler.More details about the port (copied from my comments at the top):