feature/oobaboga: Fixing merge from main (#1911)#5
Merged
jsboige merged 1 commit intojsboige:feature/oobaboogafrom Jul 12, 2023
Merged
feature/oobaboga: Fixing merge from main (#1911)#5jsboige merged 1 commit intojsboige:feature/oobaboogafrom
jsboige merged 1 commit intojsboige:feature/oobaboogafrom
Conversation
Hi, this is a new PR from a new user-level fork to account for a github bug preventing edits by maintainers on a PR made from an organization-level fork (see that [final comment](#1357 (comment)) on last PR) This PR is only an attempt at merging upstream's main for final integration of the oobabooga connector into main branch. Last set of commits made CompleteRequestSettings.MaxTokens Nullable ([#450f1d3a11eb95d6975da33f581d3997bed42906](#1367)), which broke this connector. Making TextCompletionRequest.MaxNewTokens also nullable fixed the issue. Note that Oobabooga [defaults max tokens to 200](https://github.com/oobabooga/text-generation-webui/blob/main/extensions/api/util.py#L24) Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is a new PR from a new user-level fork to account for a github bug preventing edits by maintainers on a PR made from an organization-level fork (see that final
comment on last PR)
This PR is only an attempt at merging upstream's main for final integration of the oobabooga connector into main branch. Last set of commits made CompleteRequestSettings.MaxTokens Nullable (#450f1d3a11eb95d6975da33f581d3997bed42906), which broke this connector.
Making TextCompletionRequest.MaxNewTokens also nullable fixed the issue. Note that Oobabooga defaults max tokens to
200
Motivation and Context
Description
Contribution Checklist
dotnet format