Correct MODE.SET_SPEED API#72
Closed
bazineta wants to merge 1 commit into
Closed
Conversation
Adds setupJS8() call to MODE.SET_SPEED API implementation, causing the set speed to actually be set. Fixes #50.
Contributor
Author
|
For a test harness, I've been using the js8net package, which as of yet isn't installable via Valid settings should return the speed set, e.g.: Invalid settings should return the current speed unchanged: |
Contributor
|
Notes: this merged to rc/2.3.2 for inclusion in the merge to main. Conflicts resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds setupJS8() call to MODE.SET_SPEED API implementation, causing the set speed to actually be set. Fixes #50.