Skip to content

Correct MODE.SET_SPEED API#72

Closed
bazineta wants to merge 1 commit into
js8call:mainfrom
bazineta:fix/mode_set_speed
Closed

Correct MODE.SET_SPEED API#72
bazineta wants to merge 1 commit into
js8call:mainfrom
bazineta:fix/mode_set_speed

Conversation

@bazineta

@bazineta bazineta commented Sep 1, 2025

Copy link
Copy Markdown
Contributor

Adds setupJS8() call to MODE.SET_SPEED API implementation, causing the set speed to actually be set. Fixes #50.

Adds setupJS8() call to MODE.SET_SPEED API implementation, causing the set speed to actually be set. Fixes #50.
@bazineta

bazineta commented Sep 1, 2025

Copy link
Copy Markdown
Contributor Author

For a test harness, I've been using the js8net package, which as of yet isn't installable via pip, so I just clone it locally. Test script:

import sys
sys.path.insert(0, '/Users/alb/Development/js8net')
from js8net import *
start_net("127.0.0.1", 2445)
set_speed(2)

Valid settings should return the speed set, e.g.:

>>> set_speed(2)
'2'

Invalid settings should return the current speed unchanged:

>>> set_speed(5)
'2'

@Chris-AC9KH

Copy link
Copy Markdown
Contributor

Notes: this merged to rc/2.3.2 for inclusion in the merge to main.

Conflicts resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API error, MODE.SET_SPEED

3 participants