fix exports field path#695
Closed
jackleslie wants to merge 1 commit intojs-cookie:masterfrom
jackleslie:fix-exports
Closed
fix exports field path#695jackleslie wants to merge 1 commit intojs-cookie:masterfrom jackleslie:fix-exports
exports field path#695jackleslie wants to merge 1 commit intojs-cookie:masterfrom
jackleslie:fix-exports
Conversation
hendrikmolder
approved these changes
Jul 14, 2021
Member
|
Thank you @jacklesliewise 😍 |
Member
|
(Did own commit, since we do the bumping via release-it.) |
Author
|
Awesome, thank you @carhartl - nice work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
exportsfield contains paths that are incorrect according to Node.js documentation.This throws a
ERR_INVALID_PACKAGE_TARGETerror: https://nodejs.org/api/errors.html#errors_err_invalid_package_targetThis PR fixes the issue and bumps the version