Conversation
ERCS/erc-7828.md
Outdated
| [ERC-7785]: ./ERC-7785.md | ||
| [ERC-2304]: ./ERC-2304.md | ||
| [ERC-2304]: ./eip-2304.md | ||
| [SLIP44]: https://github.com/satoshilabs/slips/blob/master/slip-0044.md |
There was a problem hiding this comment.
Are we sure SLIP are also getting referenced?
There was a problem hiding this comment.
solved on c33c60f
I found three examples where the SLIP reference was allowed, there is two options, maybe the rule is not strictly enforced consistently or i'm losing something.
- https://github.com/ethereum/ERCs/blob/5dbb684742cc08c51c906acbb787ff3378f56144/ERCS/erc-1775.md?plain=1#L169
- https://github.com/ethereum/ERCs/blob/5dbb684742cc08c51c906acbb787ff3378f56144/ERCS/erc-2304.md?plain=1#L33
- https://github.com/ethereum/ERCs/blob/5dbb684742cc08c51c906acbb787ff3378f56144/ERCS/erc-2525.md?plain=1#L55
| [ERC-7930]: ./ERC-7930.md | ||
| [ERC-7785]: ./ERC-7785.md | ||
| [ERC-2304]: ./ERC-2304.md | ||
| [ERC-2304]: ./eip-2304.md |
There was a problem hiding this comment.
Double check if EIP or ERC is the convention for link references (aside from broken bot)
There was a problem hiding this comment.
solved on 8ca4a30
after sam's last commit there is no doubt
ethereum@a062598
|
|
||
| - Using ENS as the only resolving method means it's enough to use the same Interoperable Addresses v1 for this standard, without extending it to also store the name resolver used. This means however that wallets are free to show users both resolved and unresolved (raw) Interoperable Names. | ||
|
|
||
| <!-- |
There was a problem hiding this comment.
Did open discussion got deleted or moved?
There was a problem hiding this comment.
Sam suggested commenting on it with the proposal that when the ERC is productive this section should not be read directly to avoid possible problems, since commenting on it adds an error with the bot, I decided to delete it.
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: