Fix non-native IO.popen env + kwargs handling#9351
Merged
headius merged 1 commit intojruby:jruby-9.4from Mar 31, 2026
Merged
Conversation
When both an env hash and a keyword arguments hash were provided here, the env hash logic would decrement argc resulting in the keyword arguments hash detection accessing the wrong argument. The fix here aligns this logic with the newer PopenExecutor and ensures the keyword arguments hash is handled first. The argument processing logic for these two popen implementations should be unified, but this simple fix gets popen working better right now. Fixes jruby#9295
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When both an env hash and a keyword arguments hash were provided here, the env hash logic would decrement argc resulting in the keyword arguments hash detection accessing the wrong argument. The fix here aligns this logic with the newer PopenExecutor and ensures the keyword arguments hash is handled first.
The argument processing logic for these two popen implementations should be unified, but this simple fix gets popen working better right now.
Fixes #9295