Disable AliasMethod direct binding for now#9349
Merged
headius merged 1 commit intojruby:jruby-10.0from Mar 31, 2026
Merged
Conversation
The logic here does not reflect recent changes to how alias methods are dispatched, and does not properly handle several things: * The compoundName is not passed through * The actual implementation class may not get passed in * Cases that require an implementer search are not handled The combination of these leads to issues when aliased methods are bound by indy JIT logic, so we will disable this for now and fix it properly in JRuby 10.1. Fixes jruby#8944
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic here does not reflect recent changes to how alias methods are dispatched, and does not properly handle several things:
The combination of these leads to issues when aliased methods are bound by indy JIT logic, so we will disable this for now and fix it properly in JRuby 10.1.
Fixes #8944