[fix] Bignum: use correct site for coerced comparisons#9338
Merged
headius merged 1 commit intojruby:jruby-10.0from Mar 28, 2026
Merged
[fix] Bignum: use correct site for coerced comparisons#9338headius merged 1 commit intojruby:jruby-10.0from
headius merged 1 commit intojruby:jruby-10.0from
Conversation
big_op() computed the correct CallSite for >, >=, <, <= in a switch but then ignored it and always passed sites(context).op_gt to coerceRelOp. This caused <, <=, and >= to all use > semantics when comparing a Bignum against a custom type implementing coerce. For example, (2**100) < MyCoercible.new(2**101) incorrectly returned false because it used > instead of < after coercion.
headius
approved these changes
Mar 28, 2026
Member
headius
left a comment
There was a problem hiding this comment.
Wow that's a silly mistake. Wonder if we should audit other places we use call sites. I'm open to suggestions on how to improve that.
Consider moving specs to ruby/spec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
big_op() computed the correct CallSite for >, >=, <, <= in a switch but then ignored it and always passed sites(context).op_gt to coerceRelOp. This caused <, <=, and >= to all use > semantics when comparing a Bignum against a custom type implementing coerce.
(2**100) < MyCoercible.new(2**101)incorrectly returnedfalsebecause it used > instead of < after coercion.