[fix] Bignum#eql?: use type-strict comparison (not ==)#9336
Merged
headius merged 1 commit intojruby:jruby-10.0from Mar 28, 2026
Merged
[fix] Bignum#eql?: use type-strict comparison (not ==)#9336headius merged 1 commit intojruby:jruby-10.0from
headius merged 1 commit intojruby:jruby-10.0from
Conversation
RubyBignum overrode eql_p to delegate to op_equal (==), which accepts Floats and Rationals. In Ruby, eql? must be type-strict: (2**100).eql?((2**100).to_f) should return false. Remove the override so the parent RubyNumeric.eql_p handles it correctly with a getClass() check before value comparison.
headius
approved these changes
Mar 28, 2026
Member
headius
left a comment
There was a problem hiding this comment.
Consider moving specs to ruby/spec.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RubyBignum overrode eql_p to delegate to op_equal (==), which accepts Floats and Rationals. In Ruby, eql? must be type-strict:
(2**100).eql?((2**100).to_f)should return false.Remove the override so the parent
RubyNumeric.eql_phandles it correctly with agetClass()check before value comparison.