[fix] define_method captured block propagation in JIT mode#9310
Merged
kares merged 1 commit intojruby:jruby-10.0from Mar 28, 2026
Merged
[fix] define_method captured block propagation in JIT mode#9310kares merged 1 commit intojruby:jruby-10.0from
kares merged 1 commit intojruby:jruby-10.0from
Conversation
kares
commented
Mar 16, 2026
| } | ||
| } | ||
|
|
||
| if (!blockGiven) { |
Member
Author
There was a problem hiding this comment.
seems quite ugly that we would need to be aware of the DefineMethodMethod here..
headius
approved these changes
Mar 28, 2026
Member
headius
left a comment
There was a problem hiding this comment.
This seems like an ok fix. I agree it's not great we have to know whether it's a DefineMethodMethod but there's a lot of binding code that is specific to each type of method. The long term approach would be to have the methods be responsible for building up the binding but we're not there yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
an attempt at resolving #8946