Ensure connectable sockets finish#9305
Merged
headius merged 4 commits intojruby:jruby-10.0from Mar 12, 2026
Merged
Conversation
Blocking connect logic differs on JDK versus standard C sockets.
In C sockets, a nonblocking connect followed by a select is
sufficient to finish connecting and be ready for IO.
In JDK sockets, a nonblocking connect followed by a select must
still be finished (SocketChannel.finishConnect) to set up
internal structures and move the socket out of its pending
("connection-pending"). The socket will not be usable for IO until
this finish step has been performed.
The logic here modifies IO.select to check for pending connections
after a select-for-write, and if necessary to finish the connect
process.
Fixes jruby#9304
Socket connection may have been finished elsewhere, such as by IO.select. If already connected, just return true.
2d491bf to
41a6fb7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocking connect logic differs on JDK versus standard C sockets.
In C sockets, a nonblocking connect followed by a select is sufficient to finish connecting and be ready for IO.
In JDK sockets, a nonblocking connect followed by a select must still be finished (SocketChannel.finishConnect) to set up internal structures and move the socket out of its pending ("connection-pending"). The socket will not be usable for IO until this finish step has been performed.
The logic here modifies IO.select to check for pending connections after a select-for-write, and if necessary to finish the connect process.
Fixes #9304