Only localize TracePoint to thread if specified#9283
Merged
headius merged 1 commit intojruby:jruby-10.0from Mar 3, 2026
Merged
Only localize TracePoint to thread if specified#9283headius merged 1 commit intojruby:jruby-10.0from
headius merged 1 commit intojruby:jruby-10.0from
Conversation
TracePoint#enable takes three arguments: * target: a target scope in which to enable tracing. In CRuby, this must be convertable to an instruction sequence, presumably so the instructions can be modified to trigger the event hooks. * target_line: a specific line number within the target scope to trace, I presume. The documentation does not specifically discuss this parameter. * target_thread: the sole thread on which this TracePoint should be enabled. By default, it is enabled globally. Our original code always initialized the TracePoint as being associated with the current thread at construction time, which caused it to only be triggered for events in that thread. This patch defers setting the trace thread until TracePoint#enable is called with a non-nil target_thread argument. Note that this patch also allows passing the target and target_line arguments, but they are ignored and will warn if non-nil. Fixes jruby#8697
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TracePoint#enable takes three arguments:
Our original code always initialized the TracePoint as being associated with the current thread at construction time, which caused it to only be triggered for events in that thread. This patch defers setting the trace thread until TracePoint#enable is called with a non-nil target_thread argument.
Note that this patch also allows passing the target and target_line arguments, but they are ignored and will warn if non-nil.
Fixes #8697