Restore Cleaner API use for embedding cleanup#9260
Merged
headius merged 1 commit intojruby:masterfrom Feb 24, 2026
Merged
Conversation
This reverts commit 6e877ff.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simply reverts a commit pushed to 9.4 and merged forward to 10 that switched from using the Java 9+
CleanerAPI to a traditional finalizer. JRuby 10+ requires Java 21+ so we can use the Cleaner API and eliminate this use of finalization.The original PR with the Cleaner API is here: #8561
A version of that PR that moves away from the Cleaner API is here: #8969
Because that #8969 includes the commit from #8561, the latter can't be rebased onto 10 (master) because git assumes it's the same commit and just drops it. The "cleaner" way to go back is to simply revert the commit that removed our use of the Cleaner API.
cc @matthias-fratz-bsz for review