Always cache undef along these paths#8821
Merged
headius merged 1 commit intojruby:masterfrom Apr 30, 2025
Merged
Conversation
a7dea6e to
645367a
Compare
All of these paths always passed true to cache any "undef" result, to avoid re-searching when we know nothing is there. This commit unifies all those paths and avoids a non-caching path altogether, which laterally fixes the potential (but never observed) NPE that was reported in jruby#8805.
645367a to
16a5680
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of these paths always passed true to cache any "undef" result, to avoid re-searching when we know nothing is there. This commit unifies all those paths and avoids a non-caching path altogether, which laterally fixes the potential (but never observed) NPE that was reported in #8805.
This could be an alternate fix for #8805 but I wanted to get more eyes on it.