Skip to content

Match MRI inspect values for PTY.open#7391

Merged
headius merged 1 commit intojruby:masterfrom
byteit101:nice-pty-inspect
Oct 2, 2022
Merged

Match MRI inspect values for PTY.open#7391
headius merged 1 commit intojruby:masterfrom
byteit101:nice-pty-inspect

Conversation

@byteit101
Copy link
Copy Markdown
Member

@byteit101 byteit101 commented Sep 30, 2022

Also now looks less error-y

Before:

jruby-9.3.4.0 :016 > PTY.open
 => [#<IO:fd 18>, #<File:nil>]

After/MRI:

2.6.2 :035 > PTY.open
 => [#<IO:masterpty:/dev/pts/42>, #<File:/dev/pts/42>] 

9.4.0.0 :002> PTY.open
=> [#<IO:masterpty:/dev/pts/49>, #<File:/dev/pts/49>]

@ahorek ahorek added this to the JRuby 9.4.0.0 milestone Oct 1, 2022
@headius headius merged commit 9cd1d20 into jruby:master Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

JRuby 9.4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@byteit101 @headius @ahorek