feat: support for max-depth, parallelize repo lookup#22
Merged
jrmoulton merged 2 commits intojrmoulton:mainfrom Dec 9, 2023
Merged
feat: support for max-depth, parallelize repo lookup#22jrmoulton merged 2 commits intojrmoulton:mainfrom
jrmoulton merged 2 commits intojrmoulton:mainfrom
Conversation
Owner
|
Sorry I haven't gotten a chance to review this yet. On first look this looks good but I'll dig more into it tomorrow |
|
Would love this feature! Lately tms has been pretty slow for me, and I believe it's due to it searching far deeper than I care for it to |
Owner
|
Fixes #12. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This presents an alternative approach to #20, enabling the specification of max-depth per source directory + tries to enhance the performance by using parallelization.
Changes Proposed
--max-depth(-d) to config, example usagetms config --paths /src/rust /src/go -d 1 1search_pathswill be merged into the newsearch_dirsif presentAdditional Information
The len of --paths and --max-depth should match, but if it doesn't (
tms config --paths /src/rust /src/go -d 1) then the max-depth for/src/gowould default to10.Config-Example:
Disclaimer: I know nothing about rust, although the code works it's very possible that there are issues.