Skip to content

Add marks feature#134

Merged
jrmoulton merged 2 commits intojrmoulton:mainfrom
junglerobba:marks
Nov 28, 2024
Merged

Add marks feature#134
jrmoulton merged 2 commits intojrmoulton:mainfrom
junglerobba:marks

Conversation

@junglerobba
Copy link
Collaborator

@junglerobba junglerobba commented Nov 13, 2024

closes #132

This fulfills what I would require of such a feature, but I'm taking suggestions of course.
(Including naming, unfortunately bookmark was already taken)
EDIT: Feel free to disregard the second commit if you want, I just wanted to test out this clap feature and I just so happened to have a perfect case right here

@junglerobba junglerobba force-pushed the marks branch 5 times, most recently from d2fcbc6 to ef3122e Compare November 13, 2024 17:04
@junglerobba
Copy link
Collaborator Author

with fish this is how the dynamic shell completions look like:
image

More of an experiment, but I stumbled upon this when trying to make shell
completions suggest existing marks, and I just had to add it
@jrmoulton
Copy link
Owner

This looks great. Thanks!

@jrmoulton jrmoulton merged commit db71f3b into jrmoulton:main Nov 28, 2024
@brumik
Copy link

brumik commented Feb 21, 2025

Hello, probably not the best place to ask, but when will be this feature released? I see last release from Okt. 28, bit more than 3 months ago.

@jrmoulton
Copy link
Owner

I'll see about getting one out this weekend. Thanks for the reminder :)

@junglerobba
Copy link
Collaborator Author

As an alternative, since I use it myself I try to make sure that the nix flake package provided in this repo keeps working :) that way you don’t need to rely on tagged releases

@junglerobba junglerobba deleted the marks branch May 10, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bookmarks feature

3 participants