Skip to content

fix: shellexpand final path in pick_search_path#128

Merged
jrmoulton merged 1 commit intojrmoulton:mainfrom
satoqz:shell-expand-pick-search-path
Oct 25, 2024
Merged

fix: shellexpand final path in pick_search_path#128
jrmoulton merged 1 commit intojrmoulton:mainfrom
satoqz:shell-expand-pick-search-path

Conversation

@satoqz
Copy link
Contributor

@satoqz satoqz commented Oct 24, 2024

The clone-repo and init-repo commands do not shell expand the search path they pick from the configuration via pick_search_path.

For example, my configuration is:

[[search_dirs]]
path = "~/src"

and below command:

tms clone-repo https://github.com/repo/repo

would result in the repo being cloned to $PWD/~/src/repo rather than /home/user/src/repo.

I'm assuming only the final search path that is picked in pick_search_path should be expanded such that the interactive picker still shows the unexpanded, easier to read paths first.

@jrmoulton
Copy link
Owner

Thanks!

@jrmoulton jrmoulton merged commit d82c7c9 into jrmoulton:main Oct 25, 2024
@satoqz satoqz deleted the shell-expand-pick-search-path branch October 25, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants