fix: shellexpand final path in pick_search_path#128
Merged
jrmoulton merged 1 commit intojrmoulton:mainfrom Oct 25, 2024
satoqz:shell-expand-pick-search-path
Merged
fix: shellexpand final path in pick_search_path#128jrmoulton merged 1 commit intojrmoulton:mainfrom satoqz:shell-expand-pick-search-path
jrmoulton merged 1 commit intojrmoulton:mainfrom
satoqz:shell-expand-pick-search-path
Conversation
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
clone-repoandinit-repocommands do not shell expand the search path they pick from the configuration viapick_search_path.For example, my configuration is:
and below command:
would result in the repo being cloned to
$PWD/~/src/reporather than/home/user/src/repo.I'm assuming only the final search path that is picked in
pick_search_pathshould be expanded such that the interactive picker still shows the unexpanded, easier to read paths first.