fix: don't panic when search_dir.path doesn't exist#101
Closed
ohlus wants to merge 1 commit intojrmoulton:mainfrom
Closed
fix: don't panic when search_dir.path doesn't exist#101ohlus wants to merge 1 commit intojrmoulton:mainfrom
ohlus wants to merge 1 commit intojrmoulton:mainfrom
Conversation
60a3939 to
5a6e39a
Compare
|
@petersimonsson is this ready to go? I'd love this behaviour because I'm using the same config across two machines and sometimes the directories on one don't exist the other. |
junglerobba
reviewed
Dec 2, 2024
| } | ||
| } | ||
|
|
||
| if search_dirs.is_empty() { |
Collaborator
There was a problem hiding this comment.
More of a usability thing, but maybe a warning here still makes sense if none of the configured search dirs actually exist
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If paths processed by
search_dirs()don't exist or shellexpand on them fails, they are ignored instead of a panic.I'm just learning rust, so I'm not sure if this is the right way to do it, but it's working for me.
Fixes #100