Core: Implement a node stdout reporter by leobalter · Pull Request #790 · qunitjs/qunit

leobalter · 2015-03-19T20:22:02Z

With this reporter we can use QUnit directly on npm environments:

var QUnit = require( "../dist/QUnit" );

QUnit.reporter();

require( "./unit-tests.js" );

QUnit.load();

The stdout reporter is only activated when called, this way we keep the retrocompatibility.

Log example: https://www.dropbox.com/s/07k3funzdwp0y7r/Screenshot%202015-03-19%2016.18.25.png?dl=0

The reporter function also accepts an object with the options, the only current available options is output:

// Will print a minimal report, with only dots for each assertion,
// some extra information comes on failures to help locate the issue
QUnit.reporter({
  output: "minimal"
});

// Will print a more detailed report, listing each passing assertion.
QUnit.reporter({
  output: "verbose"
});

scottgonzalez · 2015-03-19T22:37:32Z

Is the use of chalk the only thing specific to node? You might consider changing this from a node stdout reporter to a console reporter.

leobalter · 2015-03-20T15:14:32Z

The stdout reporter is also using Node's process.stdout and process.error. AFAIK, the use of console.log is limited to one line for each log, which is not what I'm aiming for here.

Maybe, it will be more clear to replace the QUnit.reporter for QUnit.stdout.

My goal in this PR is to provide a full operational reporter for Node, so we may use QUnit without any adapter.

leobalter · 2015-03-24T17:52:42Z

The stdout reporter may be followed by a TAP reporter. The one at Mocha may be used as reference.

I'll take another look to see if I detach this code from the build, and make it an individual module, so we can set it as an separate module and just require the module when QUnit.stdout is called.

leobalter · 2015-03-24T21:28:10Z

The last commit changed this PR to use the stdout reporter feature from an external module. We can turn the module a jQuery project, as you prefer.

jzaefferer · 2015-03-24T22:42:18Z

Is this still needed?

removing it.

jzaefferer · 2015-03-26T10:45:46Z

How do these tests get access to QUnit? We must be assigning global.QUnit somewhere for that to work, right?

It will use the QUnit variable assigned above. This current file test/reporter-stdout.js will work as a context module for its following requirements.

Required files in node don't have access to the scope of the file that is requiring it. So the only way for the required file to have QUnit in scope is for a global (right?). Where does the global come from?

See line 3 above.

That var QUnit shouldn't be accessible in the scope of any other files required here. Its a local variable, not made global in any way.

That's okay, but still doesn't explain why it was working before.

as I told before, this looks like an undocumented feature. Node modules seems to be leaking the current file scope to their following required modules.

Are you sure about that? QUnit does some crazy stuff with globals and different environments.

No, I'm not. I'll check this out on an example repo.

Looks like the this from outro.js refers in node to global, which we then alias as window, and in exports.js we then assign window.QUnit, which in node is the same as global.QUnit. Let's fix that.

leobalter · 2015-04-08T15:31:04Z

bumped the reporter module to 0.2.0 where I included output tests. (the minor version was due to some differences on the stderr output on failing tests)

Ref qunitjs#790 QUnit was found exported to the global object on Node environment

leobalter · 2015-08-13T16:57:18Z

By several arguments, I'm closing this PR.

We are on the way to have a release of js-reporters, as many improvement ideas came after this PR and now rebasing this is not easy.

Ref qunitjs#790 QUnit was found exported to the global object on Node environment

Ref qunitjs#790 Closes qunitjs#813 QUnit was found exported to the global object on Node environment

Core: Implement a node stdout reporter

f052b16

jquerybot added the CLA: Valid label Mar 19, 2015

leobalter added 2 commits March 20, 2015 14:55

[fixup]: fix require for case sensitive systems

d4c787e

[fixup]: rename reporter to stdout

d335244

leobalter added 2 commits March 24, 2015 14:28

[fixup]: stdout reporter is now an individual module

fd8f755

[fixup]: chalk is not a devDep

dce19be

leobalter mentioned this pull request Mar 24, 2015

ESLint JSRocksHQ/harmonic#122

Closed

[fixup]: Use the stdout as an external module

4a62158

jzaefferer reviewed Mar 24, 2015
View reviewed changes

[fixup]: fix dependencies list

b372cba

jzaefferer reviewed Mar 26, 2015
View reviewed changes

leobalter added 2 commits March 29, 2015 12:00

[fixup]: use global.QUnit to proper export QUnit

9bea625

[fixup]: update stdout reporter to 0.2.0

86e0bfb

jzaefferer mentioned this pull request Apr 14, 2015

Pendings tests #787

Closed

leobalter added a commit to leobalter/qunit that referenced this pull request Apr 22, 2015

Build: Remove unintended QUnit global export on Node

a5a1188

Ref qunitjs#790 QUnit was found exported to the global object on Node environment

leobalter mentioned this pull request Apr 22, 2015

Core: Optimize utilization of global and window variables #813

Closed

leobalter added a commit to leobalter/qunit that referenced this pull request Aug 11, 2015

Build: Remove unintended QUnit global export on Node

5972875

Ref qunitjs#790 QUnit was found exported to the global object on Node environment

leobalter closed this Aug 13, 2015

leobalter added a commit to leobalter/qunit that referenced this pull request Aug 16, 2015

Build: Remove unintended QUnit global export on Node

5854f5a

Ref qunitjs#790 QUnit was found exported to the global object on Node environment

leobalter added a commit to leobalter/qunit that referenced this pull request Aug 16, 2015

Build: Remove unintended QUnit global export on Node

16d16ba

Ref qunitjs#790 Closes qunitjs#813 QUnit was found exported to the global object on Node environment

Conversation

leobalter commented Mar 19, 2015

Uh oh!

scottgonzalez commented Mar 19, 2015

Uh oh!

leobalter commented Mar 20, 2015

Uh oh!

leobalter commented Mar 24, 2015

Uh oh!

leobalter commented Mar 24, 2015

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

leobalter commented Apr 8, 2015

Uh oh!

leobalter commented Aug 13, 2015

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants