Skip to content

All sites: Fixes broken views#388

Closed
sigorilla wants to merge 2 commits into
jquery:masterfrom
sigorilla:sigorilla.373-banner
Closed

All sites: Fixes broken views#388
sigorilla wants to merge 2 commits into
jquery:masterfrom
sigorilla:sigorilla.373-banner

Conversation

@sigorilla

Copy link
Copy Markdown
Contributor

Hi everyone!

I fixed #373 for all window widths. Also I made very big refactoring for CSS and views:

  • Fix banners on plugins (ref: Index: remove unnecessary banner jquery.org#118) and events page
  • CSS color from uppercase to lowercase
  • Indention: tab, size: 4
  • Delete px from zero values
  • Delete unnecessary properties
  • Trim all lines
  • Add space after colon in CSS properties

* Fix banners on plugins and events page
* CSS color from uppercase to lowercase
* Indention: tab, size: 4
* Delete `px` from zero values
* Delete unnecessary properties
* Trim all lines
* Add space after colon in CSS properties
@scottgonzalez

Copy link
Copy Markdown
Member

I've done a first pass over the changes and they look good to me. Still need to do a review of the actual rendering.

@kswedberg

Copy link
Copy Markdown
Member

Looks good to me, too. Checked the rendering with a bunch of sites locally.
@scottgonzalez unless you have any objections, I'm going to merge this in.

@scottgonzalez

Copy link
Copy Markdown
Member

Go for it. I've got no objections.

@kswedberg

Copy link
Copy Markdown
Member

Closed by dace041.
Thanks, @sigorilla!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

some slightly broken views on .com and .org sites

4 participants