Skip to content

Document jQuery.ready#983

Merged
mgol merged 1 commit into
jquery:masterfrom
Krinkle:jq-ready
Mar 22, 2017
Merged

Document jQuery.ready#983
mgol merged 1 commit into
jquery:masterfrom
Krinkle:jq-ready

Conversation

@Krinkle

@Krinkle Krinkle commented Sep 20, 2016

Copy link
Copy Markdown
Member

Also:

  • Categorise jQuery.holdReady in events/document-loading,
    to match ready() and jQuery.ready.promise().
  • Categorise jQuery.holdReady in properties/global-jquery-object-properties,
    to match jQuery.fx.off() and jQuery.ready.promise().

Fixes #205

@Krinkle

Krinkle commented Sep 20, 2016 •
edited
Loading

Copy link
Copy Markdown
Member Author

(Replying to now-closed pull #530)

@dmethvin Should this be documented as jQuery.ready or jQuery.ready.then? I assume the former. However we don't currently have an entry at Types for a pure "thenable". I.e. something that is not itself a $.Deferred, $.Deferred#promise or native Promise, but only returns one after calling .then().

@Krinkle Krinkle mentioned this pull request Sep 20, 2016
Closed
@dmethvin

dmethvin commented Sep 21, 2016

Copy link
Copy Markdown
Member

@Krinkle Yep, it's jQuery.ready and I think we need to create a Thenable type.

@dmethvin dmethvin mentioned this pull request Oct 5, 2016
Open
21 tasks
@Krinkle

Krinkle commented Jan 23, 2017 •
edited
Loading

Copy link
Copy Markdown
Member Author

Blocked on #906. (Add Thenable type, and update jQuery.when as receiving it in addition to Promise/jQuery.Deferred)

@Krinkle Krinkle mentioned this pull request Mar 16, 2017
Merged
@Krinkle
Document jQuery.ready
a861d17 
Also categorise jQuery.holdReady in events/document-loading and
properties/global-jquery-object-properties, to match jQuery.ready.

Fixes #205
@Krinkle

Krinkle commented Mar 21, 2017

Copy link
Copy Markdown
Member Author

Unblocked! Rebased for #1026 (landed).

@dmethvin Could you re-review?

dmethvin
dmethvin approved these changes Mar 22, 2017
View reviewed changes

@dmethvin dmethvin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, we need to mark holdReady as deprecated but there's already a ticket for that in #972 . Thanks!

@mgol mgol merged commit 7f12994 into jquery:master Mar 22, 2017
@Krinkle Krinkle deleted the jq-ready branch March 22, 2017 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmethvin dmethvin dmethvin approved these changes

@mgol mgol mgol approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Krinkle @dmethvin @mgol @jquerybot @JSFOwner