fix: string().notRequired() (#1824)

lwassermann · web-flow · commit dcb4b6381eac · 2022-11-07T17:02:35.000-05:00
diff --git a/src/string.ts b/src/string.ts
@@ -97,7 +97,7 @@ export default class StringSchema<
 
   notRequired() {
     return super.notRequired().withMutation((schema: this) => {
-      schema.tests.filter((t) => t.OPTIONS!.name !== 'required');
+      schema.tests = schema.tests.filter((t) => t.OPTIONS!.name !== 'required');
       return schema;
     });
   }
diff --git a/test/string.ts b/test/string.ts
@@ -94,6 +94,15 @@ describe('String types', () => {
     ]);
   });
 
+  it('should handle NOTREQUIRED correctly', function () {
+    let v = string().required().notRequired();
+
+    return Promise.all([
+      expect(v.isValid(undefined)).resolves.toBe(true),
+      expect(v.isValid('')).resolves.toBe(true),
+    ]);
+  });
+
   it('should check MATCHES correctly', function () {
     let v = string().matches(/(hi|bye)/, 'A message');
 

Original file line number	Diff line number	Diff line change
`@@ -97,7 +97,7 @@ export default class StringSchema<`
`97`	`97`
`98`	`98`	`notRequired() {`
`99`	`99`	`return super.notRequired().withMutation((schema: this) => {`
`100`		`- schema.tests.filter((t) => t.OPTIONS!.name !== 'required');`
	`100`	`+ schema.tests = schema.tests.filter((t) => t.OPTIONS!.name !== 'required');`
`101`	`101`	`return schema;`
`102`	`102`	`});`
`103`	`103`	`}`