Non-bugfix about zero & wide definition conflicts (again!)#110
Merged
Non-bugfix about zero & wide definition conflicts (again!)#110
Conversation
And this time, add verify-table-integrity.py as a unit test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #110 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 105 105
Branches 25 25
=========================================
Hits 105 105 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this update to update-tables.py, 04d6d90 I wrote,
In that change I used method set.discard() in error, the discard method takes a single item as an argument, while I was providing using a whole set and so it had no effect. Instead, I now use set.difference() to re-assign the set value.
Also,
category_codesargument has been removed in update-tables.py, it is not used.verify-table-integrity.pyhas been improved to show both range values in conflictverify-table-integrity.pynow included as a unit test for a single version of python (3.12)