Merged
Conversation
CodSpeed Performance ReportMerging this PR will degrade performance by 21.24%Comparing Summary
Performance Changes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #348 +/- ##
==========================================
- Coverage 98.42% 98.42% -0.01%
==========================================
Files 11 11
Lines 2607 2601 -6
Branches 460 459 -1
==========================================
- Hits 2566 2560 -6
Misses 31 31
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The boundary pattern in ``get_kitty_keyboard_state()`` used ``.+`` which matched prematurely! Existing tests didn't catch this because they use ungetch() which buffers the entire response
36541d3 to
75e094d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The boundary pattern in
get_kitty_keyboard_state()used.+which matched prematurely!Existing tests didn't catch this because they use ungetch() which buffers the entire response
The reported codspeed performance adjustment is real, ~20% less for emojis and CJK, for recent fixes in wcwidth release for "standalone" emoji variators and complex Brahmic scripts (Sanskrit etc)
jquast/wcwidth#200
jquast/wcwidth#202