bumpt checkstyle to 8.24; move checkstyle's LineLenght Check to Checker#245
Conversation
|
Thank you for this! Out of curiosity, why does the suppression not work the same way anymore? I like that the suppression works for each check in the exact same way, now I have to remember that it works differently for this specific check. Or is the style of suppressing that I'm using going to be deprecated? |
|
LineLength changed his parent from TreeWalker to Checker. This allows to use this Check on non java files( all Checks that located under Checker are not aware of AST of file they validate), as validation is super easy, just count character in line. We need to extend SuppressWithPlainTextCommentFilter to support influenceFormat checkstyle/checkstyle#7064 |
|
So if I understand you correctly, SuppressWithNearbyCommentFilter already didn't work for many of the checks? And the new issue you opened will add the ability to SuppressWithPlainTextCommentFilter to have (more or less) the same behavior as SuppressWithNearbyCommentFilter? |
Yes, as it works for Checks that validate any text file type ( not only java). Check was moved to more general area of validation, and unfortunately corresponding filter in such area has less functionality.
Yes |
|
OK, I understand now. Thanks for taking the time to explain it to me, and also thanks for making the PR in the first place! I appreciate it. |
upgrade to latest version of checkstyle to let keep using of this project in regression testing.
migration of checkstyle config is provided.
unfortunate side effect of previous suppresion stop to work due to our redesign of Filters.
new SuppressWithPlainTextCommentFilter is provided to some sort of substitution of previous functionality.