jv_parse: let decNumberFromString/strtod parse complex nans as a NaN#2985
jv_parse: let decNumberFromString/strtod parse complex nans as a NaN#2985emanuele6 merged 1 commit intojqlang:masterfrom
Conversation
|
Initially, I also added this test: # also "nan with payload" #2985
fromjson | isnan
"nan1234"
trueBut then I removed it because I realised "nan with payload" is parsed differently on the non-decnumber build ( Now I realise that many other tests in |
Yes probably a good idea to split them out. We do have https://github.com/jqlang/jq/blob/master/.github/workflows/decnum.yml but it seems to not run the standard tests... maybe it should? |
|
Should we add some kind of tests also? |
|
It used to have tests, but I removed it because it would be decNumber specific; I guess I could revert it for now since other tests in |
|
Yeap i think that would be good. After release we can maybe split out things and also make the decnum action (that builds without decnum support) run tests |
Before this patch (when using decNumber), "Nan123" was parsed as a NaN, only if the first n was uppercase.
Before this patch (when using decNumber), "Nan123" was parsed as a NaN,
only if the first n was uppercase.