Conversation
`recurse/0` already handles traversing objects and arrays, so it is more consistent to use that. For `paths/1` it is easier to use the actual value returned by ` recurse` instead of querying that value with `getpath/1` afterwards.
|
Could even use |
|
LGTM. |
|
@emanuele6 did you want to require the use of |
wader
left a comment
There was a problem hiding this comment.
LGTM but i noticed there is no tests for paths/1, time to add?
|
@wader There is something in |
Well, I thought it would look neater with Also, it would be easier to read since |
@emanuele6 I think this is true for "user" code but here the definition of After all: Shall I change it so the PR can be merged or was this only an optional suggestion? |
|
Well, it is fine with |
|
Thank you! |
recurse/0already handles traversing objects and arrays, so it is more consistent to use that.For
paths/1it is easier to use the actual value returned byrecurseinstead of querying that value withgetpath/1later.