Fix possible uninitialised value dereference if jq_init() fails#2935
Merged
nicowilliams merged 1 commit intojqlang:masterfrom Oct 22, 2023
Merged
Fix possible uninitialised value dereference if jq_init() fails#2935nicowilliams merged 1 commit intojqlang:masterfrom
nicowilliams merged 1 commit intojqlang:masterfrom
Conversation
If jq_init() fails, goto out would try to free input_state which is uninitialised. I initialised input_state to NULL to fix the problem. Ref: jqlang#2934 (comment) Reported-By: Klemens Nanni <kn@openbsd.org>
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
jq_init()fails,goto outwould try to freeinput_statewhich is uninitialised. I initialisedinput_statetoNULLto fix the problem.I also fixed
jq_util_input_init()not handling OOM errors by returningNULL, and added code to make jq exit cleanly if it returnsNULL. The codebase is filled with these kinds of problems, but this one was easy to fix, so might as well fix it now...Ref: #2934 (comment)
Reported-By: Klemens Nanni kn@openbsd.org