Merged
Conversation
This patch removes the weird behaviour of jv_invalid_with_msg(jv_null()) that returns jv_invalid() (i.e. empty), instead of a boxed jv_null(). The previous behaviour of null|error was obviously unintentional, and allowing is jv_invalid_with_msg() to return values on which you can't call jv_invalid_get_msg() is only error prone.
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch removes the weird behaviour of
jv_invalid_with_msg(jv_null())that returnsjv_invalid()(i.e. empty), instead of a boxedjv_null().The previous behaviour of
null|errorwas obviously unintentional, and allowingjv_invalid_with_msg()to return values on which you can't calljv_invalid_get_msg()is only error prone.I don't see a reason to keep and document this behaviour, it is obviously a bug, it is not useful, and it was not documented in jq 1.6.
Either way,
jv_invalid_with_msg(jv_null())should be fixed to not returnjv_invalid()in my opinion.The "
null|erroris equivalent toempty" behaviour can be implemented inf_errorif we really want to keep it.