Fix PySlice_CheckFull on 32-bit architectures#1336
Open
cjwatson wants to merge 1 commit intojpype-project:masterfrom
Open
Fix PySlice_CheckFull on 32-bit architectures#1336cjwatson wants to merge 1 commit intojpype-project:masterfrom
cjwatson wants to merge 1 commit intojpype-project:masterfrom
Conversation
When a stepping-forward slice has no upper bound, `PySlice_Unpack` sets `stop` to `PY_SSIZE_T_MAX`, not `-1`. They happen to be the same on some architectures, but that isn't portable. Fixes: jpype-project#1029
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1336 +/- ##
==========================================
+ Coverage 86.53% 86.59% +0.05%
==========================================
Files 113 113
Lines 10496 10496
Branches 4029 4029
==========================================
+ Hits 9083 9089 +6
+ Misses 814 807 -7
- Partials 599 600 +1
🚀 New features to boost your workflow:
|
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a stepping-forward slice has no upper bound,
PySlice_UnpacksetsstoptoPY_SSIZE_T_MAX, not-1. They happen to be the same on some architectures, but that isn't portable.Fixes: #1029