Fix fs.promises ExperimentalWarning on Node 10.1.0#578
Fix fs.promises ExperimentalWarning on Node 10.1.0#578RyanZim merged 1 commit intojprichardson:masterfrom bajtos:fix-experimental-warning
Conversation
JPeer264
left a comment
There was a problem hiding this comment.
I think, we should remove that as soon as the warning is gone in the Node core. Thoughts?
|
@JPeer264 Agreed, but we might still need to keep it for quite awhile, especially if all versions of Node 10 have it. |
As a consumer of fs-extra, I am happy with removing this workaround as soon as the latest Node.js 10.x version does not print the warning. |
|
Thank you for landing and publishing my fix so quickly! ❤️ 🎉 |
|
What dose it mean?And what can I do to remove this warning? The version of my node is v10.1.0. |
|
@wangjianjun0730 this warning is due to the change from |
|
You are correct |
|
Because there are so many packages depending on fs-extra, I think it's pretty much impossible to get them all to upgrade fs-extra 6.x to receive the fix. I think our best option is to wait until Node.js releases the fix - see nodejs/node#20504 In loopback-next, we temporarily pinned down the Node.js version to |
|
Hi, I just upgraded to 6.0.1 running node 10.1.0. The experimental warning went away, but the functions is not doing anything. For example const buildPath = path.resolve(__dirname, 'build'); is not deleting my build directory. Is there a work around for now? I am using this to compile my files. Thanks! |
|
@billtlee Please open a new issue with a reduced test case. |

Fixes #577
When fs-extra is loaded on Node.js 10.1.0, an experimental warning is printed:
This pull request fixes the problem by defining
fs.promisesas a getter property.@RyanZim @jprichardson could you please take a look?