refactor: remove custom getInput/getBooleanInput wrappers by joshjohanning · Pull Request #66 · joshjohanning/nodejs-actions-starter-template

joshjohanning · 2026-03-29T16:23:00Z

Remove the custom getInput() and getBooleanInput() wrapper functions and replace with direct core.getInput() and core.getBooleanInput() calls.

Why

The custom wrappers added a fallback that converted dashes to underscores in env var names (INPUT_WHO_TO_GREET instead of INPUT_WHO-TO-GREET). This was meant to help with local development since shells can't export vars with hyphens, but core.getInput() already reads INPUT_* env vars on its own - the wrapper was redundant.

Changes

Removed getInput() and getBooleanInput() functions from src/index.js
Replaced getInput() calls with core.getInput()
Replaced getBooleanInput() calls with core.getBooleanInput() for proper case-insensitive boolean handling per YAML 1.2 Core Schema
Updated local dev header comments to document how core.getInput() works with env vars
Version bump: 2.0.0 -> 2.0.1

Replace with direct core.getInput() calls. The custom wrappers added a redundant env var fallback (dash-to-underscore conversion) that core.getInput() effectively handles on its own. Update local dev header comments to reflect how core.getInput() reads INPUT_<NAME> env vars with hyphens preserved.

joshjohanning · 2026-03-29T16:24:30Z

@copilot I see we lowered our code coverage a bit, unsure if there are obvious candidate tests to add w/o being explicitly verbose or inane.

Copilot

Pull request overview

Refactors the action to remove custom input wrapper helpers and rely directly on @actions/core input APIs, simplifying input handling and updating local-development guidance accordingly.

Changes:

Removed custom getInput() / getBooleanInput() helpers and switched callers to core.getInput().
Updated local-development comment block to document hyphenated INPUT_* env var behavior.
Bumped package version and refreshed the coverage badge.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File	Description
`src/index.js`	Removes input wrapper helpers, switches to `core.getInput()`, and updates local-dev instructions.
`package.json`	Bumps package version to `2.0.1`.
`badges/coverage.svg`	Updates the displayed coverage percentage.

Agent-Logs-Url: https://github.com/joshjohanning/nodejs-actions-starter-template/sessions/c0318f92-885e-44e5-91ae-23687d2d0fd2 Co-authored-by: joshjohanning <19912012+joshjohanning@users.noreply.github.com>

…ests Agent-Logs-Url: https://github.com/joshjohanning/nodejs-actions-starter-template/sessions/c0318f92-885e-44e5-91ae-23687d2d0fd2 Co-authored-by: joshjohanning <19912012+joshjohanning@users.noreply.github.com>

Copilot · 2026-03-29T16:30:48Z

@copilot I see we lowered our code coverage a bit, unsure if there are obvious candidate tests to add w/o being explicitly verbose or inane.

Added two meaningful tests in commit 5519990:

"should log and output repo stats when token and API data are available" — covers the block (lines 110-120) where repo stats are fetched, logged, and set as the repo-stats output. The existing token test didn't mock repos.get, so getRepoStats silently returned null and that block was never reached.
"should fall back to console logging when summary write fails" — covers the inner catch block (lines 151-153) that logs results to console when core.summary.write() rejects.

Also fixed a pre-existing mock leak while I was at it: the "should handle errors gracefully" test was using mockImplementation (persistent) to make setOutput throw, which silently poisoned all subsequent tests. Changed it to mockImplementationOnce so the throw only fires once.

Coverage improved from 72.91% → 97.91% statements and 48% → 80% branches. The only uncovered line remaining is the import.meta.url direct-execution guard, which isn't practically testable in Jest.

Addresses Copilot review feedback — the previous === 'true' check was case-sensitive and would silently treat True/TRUE as false. core.getBooleanInput handles case variations per the Actions API.

Copilot

Pull request overview

Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.

Prevents mock return value from persisting across tests since jest.clearAllMocks does not reset mock implementations.

Copilot

Pull request overview

Copilot reviewed 3 out of 5 changed files in this pull request and generated 3 comments.

- Use mockReturnValueOnce/mockResolvedValueOnce/mockRejectedValueOnce to prevent mock state leaking across tests - Remove 'inline assignment' wording from local dev docs for consistency with other repos

Copilot

Pull request overview

Copilot reviewed 3 out of 5 changed files in this pull request and generated 2 comments.

- Update README to use env(1) with hyphenated INPUT_* names, consistent with header comment and other repos - Set getBooleanInput default to false in beforeEach for realistic mock behavior

Copilot

Pull request overview

Copilot reviewed 4 out of 6 changed files in this pull request and generated no new comments.

github-actions · 2026-03-30T20:20:30Z

📦 Draft Release Created

A draft release v2.0.1 has been created for this PR.

🔗 View Draft Release

Next Steps

Review the release notes
Publish the release to make it permanent

This is an automated reminder from the publish-github-action workflow.

Copilot AI review requested due to automatic review settings March 29, 2026 16:23

Copilot started reviewing on behalf of joshjohanning March 29, 2026 16:23 View session

Copilot started work on behalf of joshjohanning March 29, 2026 16:24 View session

Copilot AI reviewed Mar 29, 2026

View reviewed changes

Comment thread src/index.js Outdated

Copilot AI and others added 2 commits March 29, 2026 16:26

chore: initial plan for coverage improvements

4c6f983

Agent-Logs-Url: https://github.com/joshjohanning/nodejs-actions-starter-template/sessions/c0318f92-885e-44e5-91ae-23687d2d0fd2 Co-authored-by: joshjohanning <19912012+joshjohanning@users.noreply.github.com>

Copilot finished work on behalf of joshjohanning March 29, 2026 16:31

joshjohanning added 2 commits March 29, 2026 14:55

chore: update coverage badge

5ef9c87

fix: use core.getBooleanInput for include-time input

84c1df4

Addresses Copilot review feedback — the previous === 'true' check was case-sensitive and would silently treat True/TRUE as false. core.getBooleanInput handles case variations per the Actions API.

joshjohanning requested a review from Copilot March 30, 2026 19:20

Copilot started reviewing on behalf of joshjohanning March 30, 2026 19:21 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

Comment thread src/index.js

Comment thread __tests__/index.test.js

fix: use mockReturnValueOnce for getBooleanInput in tests

90064c6

Prevents mock return value from persisting across tests since jest.clearAllMocks does not reset mock implementations.

joshjohanning requested a review from Copilot March 30, 2026 19:49

Copilot started reviewing on behalf of joshjohanning March 30, 2026 19:49 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

Comment thread src/index.js Outdated

Comment thread __tests__/index.test.js Outdated

Comment thread __tests__/index.test.js Outdated

fix: use mockOnce patterns and update local dev docs

0e053a2

- Use mockReturnValueOnce/mockResolvedValueOnce/mockRejectedValueOnce to prevent mock state leaking across tests - Remove 'inline assignment' wording from local dev docs for consistency with other repos

joshjohanning requested a review from Copilot March 30, 2026 19:56

Copilot started reviewing on behalf of joshjohanning March 30, 2026 19:57 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

Comment thread src/index.js

Comment thread __tests__/index.test.js

fix: update README local dev docs and set getBooleanInput default

55703de

- Update README to use env(1) with hyphenated INPUT_* names, consistent with header comment and other repos - Set getBooleanInput default to false in beforeEach for realistic mock behavior

joshjohanning requested a review from Copilot March 30, 2026 20:05

Copilot started reviewing on behalf of joshjohanning March 30, 2026 20:06 View session

Copilot AI reviewed Mar 30, 2026

View reviewed changes

joshjohanning merged commit 119c81b into main Mar 30, 2026
8 checks passed

joshjohanning deleted the remove-custom-getinput branch March 30, 2026 20:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: remove custom getInput/getBooleanInput wrappers#66

refactor: remove custom getInput/getBooleanInput wrappers#66
joshjohanning merged 8 commits into
mainfrom
remove-custom-getinput

joshjohanning commented Mar 29, 2026 •

edited

Loading

Uh oh!

joshjohanning commented Mar 29, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI commented Mar 29, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

github-actions Bot commented Mar 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

joshjohanning commented Mar 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

Changes

Uh oh!

joshjohanning commented Mar 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI commented Mar 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

github-actions Bot commented Mar 30, 2026

📦 Draft Release Created

Next Steps

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

joshjohanning commented Mar 29, 2026 •

edited

Loading