Skip to content

Follow-up to #92: fix misleading summary failure header #94

@joshjohanning

Description

@joshjohanning

Parent: #92

Context

Issue #92 includes two concerns:

  1. Controlling when job summaries are written (handled separately)
  2. The summary header can show a failure-style message even when the action/job does not actually fail

This issue tracks concern # 2 only.

Problem

The current summary header wording implies an outright failure in cases where results include unsupported references (or other non-fatal findings) but the action does not call setFailed.

Goal

Adjust summary header semantics so the top-level message accurately reflects actual run outcome vs findings severity.

Scope

  • Update summary header logic/text in src/index.js
  • Keep behavior aligned with fail-on-mutable and actual failure paths
  • Add/update tests in __tests__/index.test.js
  • Update README wording if behavior/user-facing semantics change

Acceptance criteria

  • Header wording is accurate for:
    • fully passing runs
    • runs with findings that do not fail the action
    • runs that truly fail the action
  • Tests cover the above cases
  • Documentation is consistent with resulting behavior

cc @Wuodan

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions