Skip to content

chore(deps-dev): add globals package as a direct dev dependency#66

Merged
joshjohanning merged 1 commit into
mainfrom
deps/explicitly-add-globals
Jan 6, 2026
Merged

chore(deps-dev): add globals package as a direct dev dependency#66
joshjohanning merged 1 commit into
mainfrom
deps/explicitly-add-globals

Conversation

@joshjohanning

Copy link
Copy Markdown
Owner

This pull request makes a minor update to the project's dependencies in package.json, adding the globals package to the list of development dependencies.

It was being indirectly referenced before as a transitive dependency in jest, now it's directly added since we do import globals.

Copilot AI review requested due to automatic review settings January 6, 2026 20:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the globals package as a direct development dependency to properly declare a package that is already being imported and used in the codebase.

Key Changes:

  • Added globals@^17.0.0 to devDependencies in package.json
  • Updated package-lock.json with the new dependency version (17.0.0) and maintained version 14.0.0 as a nested dependency for @eslint/eslintrc

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
package.json Added globals package (version ^17.0.0) to devDependencies list
package-lock.json Updated the main globals entry from version 14.0.0 to 17.0.0 and added version 14.0.0 as a nested dependency under @eslint/eslintrc

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@joshjohanning joshjohanning merged commit 1811795 into main Jan 6, 2026
10 checks passed
@joshjohanning joshjohanning deleted the deps/explicitly-add-globals branch January 6, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants