Fix v2: only break on authorized /approve, not first match#100
Merged
Conversation
Previously the break executed on any /approve comment match, so if a non-team-member commented /approve before a valid team member, the action would stop checking and report unauthorized. Now the break only executes after confirming the commenter is in the required team, allowing later valid approvals to be found. Fixes #98
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V2 Hotfix
Bug
The shell script
breaks out of the comment loop on the first/approvematch, regardless of whether the commenter is in the required team. If a non-team-member comments/approvebefore a valid team member, the action fails even though a valid approval exists.Fix
Moved the
breakinside the authorization check so it only exits the loop when a team member's/approveis found. Non-team-member/approvecomments are now skipped and the loop continues.Release steps
release/v2v2.0.6fromrelease/v2v2tag to point tov2.0.6v2.0.6Fixes #98