Merged
Conversation
Resolves #15
Owner
Author
Contributor
|
Thank you! Looks good to me! |
Owner
Author
|
Thanks @spaceone, I am going to try to get a few more changes knocked out tonight, then will cut a new release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix backslash escaping and verify compatibility with go-logfmt/logfmt which is used by tools such as Grafana/Loki.
Testing Notes
The new external tools compatibility tests require that the tools in
./externalare built and onPATH. The only tool being used currently is "golang-logfmt-echo" which simply wraps go-logfmt/logfmt, a popular logfmt library used by Grafana. This tool is built automatically with Nix. If you aren't using Nix, you will need to build it manually or skip this test withpytest -m "not external".Issues
Resolves #15
References