Fix detection of dumb terminals on Windows#91
Merged
kibertoad merged 1 commit intojorgebucaran:mainfrom Jun 3, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #91 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 145 146 +1
=========================================
+ Hits 145 146 +1
Continue to review full report at Codecov.
|
kibertoad
approved these changes
Jun 3, 2022
Collaborator
|
Thank you! |
Owner
|
Thank you, @MartinKolarik, @kibertoad! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default Windows terminal doesn't set
env.TERMso we cannot require the variable to be set like on other platforms but if it is set, we should use it because there are many third-party terminals, particularly those embedded in various GUI apps, that don't support colors and correctly set this variable. Fixes #90.Precommit checks in GitHub Desktop app (before):
After: