Rest: configure HTTP/1.1 version as default for client instead of request#47
Merged
henryx merged 1 commit intojopenlibs:masterfrom Aug 15, 2023
Merged
Conversation
…uest to allow HTTP/2 connection negotiation if custom http client is provided. Keeping default to HTTP/1.1 for builtin client is caused by inability of Vault Agent API to proxy unsecured HTTP/2 (h2c) connections to secured HTTPS (covered by the io.github.jopenlibs.vault.api.VaultAgentTests.testWriteAndReadFromAgent test).
Collaborator
|
Thank you for the PR, I've merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows HTTP/2 connection negotiation if custom http client is provided.
At first I wanted to remove this forcing of "legacy" HTTP/1 protocol, but couldn't pass integration test for Vault Agent: io.github.jopenlibs.vault.api.VaultAgentTests.testWriteAndReadFromAgent,
because Vault Agent failed to proxy unsecured HTTP/2 (h2c) connections to secured HTTPS.
Therefore I kept default to HTTP/1.1 for builtin client.