Skip to content

Update models.py - Add Set-Top Box STB#389

Merged
joostlek merged 2 commits into
joostlek:mainfrom
yannpub:main
Nov 8, 2024
Merged

Update models.py - Add Set-Top Box STB#389
joostlek merged 2 commits into
joostlek:mainfrom
yannpub:main

Conversation

@yannpub

@yannpub yannpub commented Nov 7, 2024

Copy link
Copy Markdown
Contributor

Proposed Changes

Add Device type STB (Set-Top Box).

Related Issues

Issue in HA Spotify integration showing

File "", line 24, in mashumaro_from_dict_json
File "/usr/local/lib/python3.12/enum.py", line 757, in call
return cls.new(cls, value)
^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.12/enum.py", line 1171, in new
raise ve_exc
ValueError: 'STB' is not a valid DeviceType

See similar issue : home-assistant/core#129704

Comment thread src/spotifyaio/models.py Outdated
@joostlek joostlek added the bugfix Inconsistencies or issues which will cause a problem for users or implementers. label Nov 7, 2024
@joostlek

joostlek commented Nov 7, 2024

Copy link
Copy Markdown
Owner

Awesome thanks. I'll probably merge tomorrow

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5baee5f) to head (7c7ce41).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #389   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          661       662    +1     
  Branches        28        28           
=========================================
+ Hits           661       662    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joostlek joostlek merged commit 9f3b2a6 into joostlek:main Nov 8, 2024
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix Inconsistencies or issues which will cause a problem for users or implementers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants