Skip to content

Fixed left sidebar layout issue.#233

Closed
Achal-Aggarwal wants to merge 1 commit intojoomla-projects:developfrom
Achal-Aggarwal:sidebar-fix
Closed

Fixed left sidebar layout issue.#233
Achal-Aggarwal wants to merge 1 commit intojoomla-projects:developfrom
Achal-Aggarwal:sidebar-fix

Conversation

@Achal-Aggarwal
Copy link
Copy Markdown
Contributor

Before:
image

After:
image
image

@infograf768
Copy link
Copy Markdown
Contributor

Please explain what are the results of the changes~:
screenshot before and after.
For me here it breaks totally the display
when collapsed, the table disapears
when not collapsed, the table displays below the sidebar

@infograf768
Copy link
Copy Markdown
Contributor

The reason we have these 2 closing divs for the moment is that the filters are not added to the sidebar.
Therefore was added a custom layout /sidebars/submenu where they are absent.
Once we have modified the code to be able to use JHtmlSidebar::addFilter(), we will be able to correct this.

@Achal-Aggarwal
Copy link
Copy Markdown
Contributor Author

We need to take care of this once joomla/joomla-cms#4450 is sorted out.

@infograf768
Copy link
Copy Markdown
Contributor

obsolete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants