Conversation
|
I'm not sure if this is a good idea, having a class behaving different without being able to check what method is uses. also I think this should be it's own class, maybe extend But as this pr is I don't think it's a good approach tbh. |
Can add method to check it, if realy need.
Also as an option, I can make as own class. Any other opinions? :) |
|
Maybe as alternative way, can do check for non empty separator before each call of: This will be kind of the same (but not really). Currently "empty separator" will cause error. |
|
I made PR for empty separator #66 |
|
The pr for a new class #67 for flat registry |
|
Looks good but I noticed that $data is a stdClass no idea why. Also I would make this class final. |
Summary of Changes
The changes should allow to use registry in Flattened mode.
This should speed up the Registry, in cases when nested access to Data does not needed.
Testing Instructions
Unit testing passes.
Documentation Changes Required
New parameters for Registry constructor, that enable Flattened mode.