This repository was archived by the owner on Feb 4, 2026. It is now read-only.
Change scheme for the google maps api call to https and include an api key if one was set#10
Merged
mbabker merged 3 commits intojoomla-framework:masterfrom May 13, 2016
matrikular:patch-1
Merged
Change scheme for the google maps api call to https and include an api key if one was set#10mbabker merged 3 commits intojoomla-framework:masterfrom matrikular:patch-1
mbabker merged 3 commits intojoomla-framework:masterfrom
matrikular:patch-1
Conversation
…i key if one was set
src/Embed/Maps.php
Outdated
| { | ||
| $url = 'http://maps.googleapis.com/maps/api/geocode/json?sensor=false&address=' . urlencode($address); | ||
| $response = $this->http->get($url); | ||
| $uri = JUri::getInstance('https://maps.googleapis.com/maps/api/geocode/json'); |
Contributor
There was a problem hiding this comment.
This needs to be new Uri('https://maps.googleapis.com/maps/api/geocode/json');
The JUri class doesn't exist at the Framework level
Contributor
Author
There was a problem hiding this comment.
Thank you michael, I already changed it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in #10439 for the joomla-cms repo, this PR aims to add a google api key to the request if one was set and changes the schema / protocol to https instead of http.