generic utf-8 multibyte cases which cause the filter to fail.#24
Merged
mbabker merged 2 commits intojoomla-framework:masterfrom May 10, 2017
Merged
generic utf-8 multibyte cases which cause the filter to fail.#24mbabker merged 2 commits intojoomla-framework:masterfrom
mbabker merged 2 commits intojoomla-framework:masterfrom
Conversation
Contributor
Author
|
Maybe I didn't understand how the test setup here was working. Seems I've fixed the tests set up so the simple use of Persian characters is validated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue create some generic utf-8 multibyte test cases to show problems
Summary of Changes
creates some generic utf-8 multibyte test cases
Testing Instructions
Tests should pass, but notice that the simple use of Persian characters breaks the tests even though they copy the "Fred" generic cases.