[fix] openbase_dir processing#20
Merged
mbabker merged 1 commit intojoomla-framework:masterfrom Jun 2, 2018
rvalitov:master
Merged
[fix] openbase_dir processing#20mbabker merged 1 commit intojoomla-framework:masterfrom rvalitov:master
mbabker merged 1 commit intojoomla-framework:masterfrom
rvalitov:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for joomla/joomla-cms#20280
Summary of Changes
If the open_basedir ini directive contains a path that links to a
symlink, PHP will resolve these paths and then perform the acutal
access check.
Joomla, however, only performed a plain string comparison. As a
result leading to false positives.
Testing Instructions
Expected result
This should just work with no erorrs whatsoever.
Actual result
An error is presented that the path is not within open_basedir..
Documentation Changes Required
No